- Sep 13, 2016
-
-
Mark Haines authored
-
Mark Haines authored
-
Mark Haines authored
-
Mark Haines authored
-
Mark Haines authored
Some clients expect the session id to be globally unique, so allowing the end devices to pick the session id will cause problems. Include the current ratchet index with the initial keys, this decreases the risk that the client will supply the wrong index causing problems. Sign the initial keys with the ratchet ed25519 key, this reduces the risk of a client claiming a session that they didn't create.
-
- Sep 06, 2016
-
-
Richard van der Hoff authored
Add ed25519 keys to the inbound and outbound sessions, and use them to sign and verify megolm messages. We just stuff the ed25519 public key in alongside the megolm session key (and add a version byte), to save adding more boilerplate to the JS/python/etc layers.
-
- Sep 05, 2016
-
-
Richard van der Hoff authored
... so that I can use them from the group session bits.
-
Richard van der Hoff authored
-
Richard van der Hoff authored
-
- Sep 04, 2016
-
-
Richard van der Hoff authored
I find myself wanting to know if an OlmSession is in the pre-key state or not, to help debugging at the application level.
-
- Sep 02, 2016
-
-
Richard van der Hoff authored
We were using olm::KEY_LENGTH for everything under the sun which happened to be 32 bytes long, and making a bunch of assumptions in the process. Create a bunch of new constants (as C #defines rather than C++ consts so that I can use them in another forthcoming refactor).
-
- Sep 01, 2016
-
-
Richard van der Hoff authored
Ed25519 private keys, it turns out, have 64 bytes, not 32. We were previously generating only 32 bytes (which is all that is required to generate the public key), and then using the public key as the upper 32 bytes when generating the per-message session key. This meant that everything appeared to work, but the security of the private key was severely compromised. By way of fixes: * Use the correct algorithm for generating the Ed25519 private key, and store all 512 bits of it. * Update the account pickle format and refuse to load the old format (since we should consider it compromised). * Bump the library version, and add a function to retrieve the library version, so that applications can verify that they are linked against a fixed version of the library. * Remove the curve25519_{sign, verify} functions which were unused and of dubious quality.
-
- Jun 30, 2016
-
-
Richard van der Hoff authored
* write V1 pickles on the master branch * the logging branch is going to write v0x80000001
-
Richard van der Hoff authored
Keeping track of the chain index is a useful thing to do, but is only required if we've enabled diagnostics. Extend the session pickle format to make a space for it, so that pickles can be transferred between the logging_enabled branch and the master branch without loss of information. Also add some tests for session pickling which explicitly check that we can unpickle both formats of pickle.
-
Richard van der Hoff authored
This was introduced when I was experimenting with support for logging progress in Olm. That is now relegated to the logging_enabled branch, so this should probably be removed. This also fixes the incompatibility of session pickles from the current master branch with those from olm 0.1.0.
-
- May 25, 2016
-
-
Richard van der Hoff authored
Putting the session_id inside the packed message body makes it hard to extract so that we can decide which session to use. We don't think there is any advantage to having thes sesion_id protected by the HMACs, so we're going to move it to the JSON framing.
-
Richard van der Hoff authored
sha256.c and aes.c contain conflicting declarations, so we need to compile them as separate units. This requires a bit more Makefile-shuffling; the build directory now includes 'src' or 'lib' as appropriate, and we just mkdir -p before each compilation.
-
Richard van der Hoff authored
-
Mark Haines authored
-
- May 24, 2016
-
-
Richard van der Hoff authored
-
Richard van der Hoff authored
There was some slightly overcomplex logic designed to save a couple of hash operations when R(0) and R(1) were advanced, but the extra code was hard to understand and didn't save much.
-
Richard van der Hoff authored
We no longer need to keep track of intermediate values of the counter, which means we can update it much more easily.
-
Richard van der Hoff authored
These were left over from when rehash_part did a bunch of logging.
-
Richard van der Hoff authored
Factor the actual message encoding/decoding and encrypting/decrypting out to separate functions from the top-level functions which do the base64-wrangling. This is particularly helpful in the 'outbound' code-path where the offsets required to allow room to base64-encode make the flow hard to see when it's all inline.
-
Richard van der Hoff authored
Initialise megolm_cipher via the preprocessor macro, instead of with a function.
-
Richard van der Hoff authored
Some of the crypto libs rely on UINT64_C, which in glibc 2.17 and earlier was not defined for C++ code (see https://sourceware.org/bugzilla/show_bug.cgi?id=15366).
-
Richard van der Hoff authored
memset is at risk of being optimised away, so use _olm_unset instead.
-
Richard van der Hoff authored
The behaviour when casting from a uint32_t which has overflowed (so has the top bit set) to int32_t is implementation-defined, so let's avoid relying on it.
-
Richard van der Hoff authored
Make names (of session_key and message_index) more consistent. Use our own protobuf tags rather than trying to piggyback on the one-to-one structure.
-
Richard van der Hoff authored
-
Richard van der Hoff authored
Includes creation of inbound sessions, etc
-
Richard van der Hoff authored
We need to be able to inspect an outbound session so that we can tell our peer how to set up an inbound session.
-
Richard van der Hoff authored
-
Richard van der Hoff authored
-
Richard van der Hoff authored
-
Richard van der Hoff authored
We don't need to have all of the top-level pickling functions in olm.cpp; factor out the utilities to support it to pickle_encoding.cpp (and make sure that they have plain-C bindings).
-
Richard van der Hoff authored
I want to be able to use this functionality from elsewhere, so factor it out to its own file.
-
Richard van der Hoff authored
Replace the init-static-var dance with some preprocessor macros
-
Richard van der Hoff authored
We never delete a cipher, and the destruct op is empty, so it's a bit pointless
-
- May 23, 2016
-
-
Mark Haines authored
-