Fix bugs and pass JSON tests for requests

lib/structs/requests.cpp

@@ -137,7 +137,7 @@ to_json(json &obj, const PublicRooms &request)
                 throw std::invalid_argument("third_party_instance_id id can only be set if include_all_networks is false");
         }
         obj["third_party_instance_id"] = request.third_party_instance_id;
-        obj["include_all_networks"] = !request.third_party_instance_id.empty();
+        obj["include_all_networks"] = request.third_party_instance_id.empty();
 }
 
 void

tests/requests.cpp

@@ -314,6 +314,7 @@ TEST(Requests, PublicRooms)
       "generic_search_term" : "foo"
     },
     "include_all_networks" : false,
+    "since" : "",
     "third_party_instance_id" : "irc"
   })"_json);
             
@@ -325,6 +326,8 @@ TEST(Requests, PublicRooms)
   EXPECT_EQ(j, R"({
     "limit" : 10,
     "include_all_networks" : false,
+    "since": "",
+    "filter": {"generic_search_term":""},
     "third_party_instance_id" : "matrix"
   })"_json);