Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
nheko
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Nheko Reborn
nheko
Commits
35601b6b
Commit
35601b6b
authored
4 years ago
by
Nicolas Werner
Browse files
Options
Downloads
Patches
Plain Diff
Terminate user color calculation, when no solution can be found
fixes #172
parent
0e1bb513
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
CHANGELOG.md
+1
-0
1 addition, 0 deletions
CHANGELOG.md
src/Utils.cpp
+6
-0
6 additions, 0 deletions
src/Utils.cpp
with
7 additions
and
0 deletions
CHANGELOG.md
+
1
−
0
View file @
35601b6b
...
...
@@ -12,6 +12,7 @@
-
Fix crash when trying to maximize image, that wasn't downloaded yet.
-
Fix Binding restorMode flooding logs on Qt 5.14.2+
-
Fix with some qml styles hidden menu items leave empty space
-
Fix hangs when generating colors with some system theme color schemes (#172)
## [0.7.0] -- 2020-04-19
...
...
This diff is collapsed.
Click to expand it.
src/Utils.cpp
+
6
−
0
View file @
35601b6b
...
...
@@ -540,6 +540,7 @@ utils::generateContrastingHexColor(const QString &input, const QString &backgrou
// If the contrast doesn't meet our criteria,
// try again and again until they do by modifying first
// the lightness and then the saturation of the color.
int
iterationCount
=
9
;
while
(
contrast
<
5
)
{
// if our lightness is at it's bounds, try changing
// saturation instead.
...
...
@@ -586,6 +587,11 @@ utils::generateContrastingHexColor(const QString &input, const QString &backgrou
}
}
}
// don't loop forever, just give up at some point!
// Someone smart may find a better solution
if
(
--
iterationCount
<
0
)
break
;
}
// get the hex value of the generated color.
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment