Skip to content
Snippets Groups Projects
  • Nicolas Werner's avatar
    23eef9e1
    Simplify linkifyMessage · 23eef9e1
    Nicolas Werner authored
    Parsing html as xml has inherent problems, most notable there are many
    matrix clients that don't escape ampersands in urls of mx-replies, etc.
    (See issue #18)
    
    This also removes the replacement of <mx-reply> as it isn't strictly
    needed.
    
    Also the QRegExp is replaced with the Qt5 QRegularExpression for
    perfomance and because it supports lookahead and lookbehind.
    
    I'm pretty sure that the original code also replaced href="" with
    href=\"\", which was probably wrong, but I'm not to sure about that.
    
    Fixes #18
    23eef9e1
    History
    Simplify linkifyMessage
    Nicolas Werner authored
    Parsing html as xml has inherent problems, most notable there are many
    matrix clients that don't escape ampersands in urls of mx-replies, etc.
    (See issue #18)
    
    This also removes the replacement of <mx-reply> as it isn't strictly
    needed.
    
    Also the QRegExp is replaced with the Qt5 QRegularExpression for
    perfomance and because it supports lookahead and lookbehind.
    
    I'm pretty sure that the original code also replaced href="" with
    href=\"\", which was probably wrong, but I'm not to sure about that.
    
    Fixes #18
Code owners
Assign users and groups as approvers for specific file changes. Learn more.