Skip to content
Snippets Groups Projects
  1. Oct 04, 2018
  2. Sep 25, 2018
    • David Baker's avatar
      Another day, another interface · 263b9442
      David Baker authored
      Change the interface again, hopefully this time a bit more normal.
      Now we wrap the emscripten module completely and just expose the
      high level objects.
      
      The olm library export is now imported as normal (ie. returns
      a module rather than a function returning a module) but has an
      `init` method which *must* be called. This returns a promise
      which resolves when the module is ready. It also rejects if the
      module failed to set up, unlike before (and unlike the
      promise-not-a-promise that emscripten returns).
      
      Generally catch failures to init the module.
      263b9442
  3. Sep 21, 2018
    • David Baker's avatar
      WebAssembly support! · 122867c4
      David Baker authored
      Quite a lot going on in this PR:
       * Updates to support recent emscripten, switching to WASM which is now the default
       * Use emscripten's MODULARIZE option rather than wrapping it ourself, since doing
         so in pre-post js doesn't work anymore.
       * Most changes are moving the emscripten runtime functions to top-level
         calls rather than in the Module object.
       * Get rid of duplicated NULL_BYTE_PADDING_LENGTH
       * Fix ciphertext_length used without being declared
       * Fix things that caused the closure compiler to error, eg. using
         OLM_OPTIONS without a declaration.
       * Wait until module is inited to do OLM_ERROR = olm_error()
      
      The main BREAKING CHANGE here is that the module now needs to initialise
      asyncronously (because it has to load the wasm file). require()ing olm
      now gives a function which needs to be called to create an instance.
      The resulting object has a promise-like then() method that can be used
      to detect when the module is ready. (We could use MODULARIZE_INSTANCE
      to return the module directly as before, rather than the function,
      but then we don't get the .then() method).
      122867c4
  4. Jun 27, 2018
  5. Jan 09, 2018
  6. Dec 16, 2016
    • Richard van der Hoff's avatar
      Avoid buffer overrun on encryption · 8e554ab5
      Richard van der Hoff authored
      Make sure we null-terminate encrypted strings before passing them to
      UTF8ToString.
      
      This used to work when we allocated the buffer on the stack, because it turns
      out that allocate() zeroinits the returned memory. malloc(), of course, does
      not.
      8e554ab5
  7. Dec 15, 2016
  8. Dec 14, 2016
  9. Dec 12, 2016
  10. Sep 04, 2016
    • Richard van der Hoff's avatar
      Fix megolm decryption of UTF-8 · 1d4c13c7
      Richard van der Hoff authored
      Repeat the fix from b10f90d for megolm messages.
      
      It turns out that the 'length' argument to 'Pointer_stringify' doesn't work if
      the input includes characters >= 128.
      
      Rather than try to figure out which methods can return UTF-8, and which always
      return plain ascii, replace all uses of Pointer_stringify with a 'length'
      argument with the version that expects a NULL-terminated input, and extend the
      buffer by a byte to allow space for a null-terminator.
      
      In the case of decrypt, we need to add the null ourself.
      
      Fixes https://github.com/vector-im/vector-web/issues/2078.
      1d4c13c7
    • Richard van der Hoff's avatar
      OlmSession.has_received_message · 2e9021c2
      Richard van der Hoff authored
      I find myself wanting to know if an OlmSession is in the pre-key state or not,
      to help debugging at the application level.
      2e9021c2
  11. Sep 01, 2016
    • Richard van der Hoff's avatar
      Fix Ed25519 keypair generation · 0c462cff
      Richard van der Hoff authored
      Ed25519 private keys, it turns out, have 64 bytes, not 32.
      
      We were previously generating only 32 bytes (which is all that is required to
      generate the public key), and then using the public key as the upper 32 bytes
      when generating the per-message session key. This meant that everything
      appeared to work, but the security of the private key was severely compromised.
      
      By way of fixes:
      
       * Use the correct algorithm for generating the Ed25519 private key, and store
         all 512 bits of it.
      
       * Update the account pickle format and refuse to load the old format (since we
         should consider it compromised).
      
       * Bump the library version, and add a function to retrieve the library
         version, so that applications can verify that they are linked against a
         fixed version of the library.
      
       * Remove the curve25519_{sign, verify} functions which were unused and of
         dubious quality.
      0c462cff
  12. Jul 06, 2016
    • Richard van der Hoff's avatar
      JS: make sure returned strings are null-terminated · 939aa747
      Richard van der Hoff authored
      It turns out that the 'length' argument to 'Pointer_stringify' doesn't work if
      the input includes characters >= 128.
      
      Rather than try to figure out which methods can return UTF-8, and which always
      return plain ascii, replace all uses of Pointer_stringify with a 'length'
      argument with the version that expects a NULL-terminated input, and extend the
      buffer by a byte to allow space for a null-terminator.
      
      In the case of decrypt, we need to add the null ourself.
      
      Fixes https://github.com/vector-im/vector-web/issues/1719.
      939aa747
  13. May 16, 2016
  14. Apr 26, 2016
  15. Aug 04, 2015
  16. Jul 21, 2015
  17. Jul 17, 2015
  18. Jul 16, 2015
  19. Jul 14, 2015
  20. Jul 10, 2015
  21. Jul 09, 2015
  22. Jul 08, 2015
  23. Jun 26, 2015
  24. Jun 24, 2015
  25. Jun 23, 2015
Loading