diff --git a/include/axolotl/list.hh b/include/axolotl/list.hh index ae41baa1e8cd67dbd363408e51c266f7f30afa4f..a3c3d01e06d3ccb864da14f33a43ffb94d50b584 100644 --- a/include/axolotl/list.hh +++ b/include/axolotl/list.hh @@ -18,12 +18,12 @@ public: /** * Is the list empty? */ - bool empty() { return _end == _data; } + bool empty() const { return _end == _data; } /** * The number of items in the list. */ - std::size_t size() { return _end - _data; } + std::size_t size() const { return _end - _data; } T & operator[](std::size_t index) { return _data[index]; } diff --git a/include/axolotl/message.hh b/include/axolotl/message.hh index 85579cf300d829e84108718c4880729ea46ddb4f..ac4b3e0f4eaf3856fcd1a293bf0fdeb6ae07897b 100644 --- a/include/axolotl/message.hh +++ b/include/axolotl/message.hh @@ -29,7 +29,6 @@ struct MessageReader { std::uint32_t counter; std::size_t ratchet_key_length; std::size_t ciphertext_length; - std::size_t mac_length; std::uint8_t const * ratchet_key; std::uint8_t const * ciphertext; std::uint8_t const * mac; diff --git a/src/message.cpp b/src/message.cpp index d0e45e0401ab6fecb5fda8a34a822fa559c0511a..18dbe0ea1475cfb28f7e83e6f88759893f22a35b 100644 --- a/src/message.cpp +++ b/src/message.cpp @@ -120,7 +120,6 @@ axolotl::MessageReader axolotl::decode_message( std::uint8_t const * end = input + input_length - mac_length; std::uint8_t flags = 0; result.mac = end; - result.mac_length = mac_length; if (pos == end) return result; result.version = *(pos++); while (pos != end) { diff --git a/tests/test_message.cpp b/tests/test_message.cpp index a09d7e786707ccd2102761b19518ca8e59b6ef2d..242243b81284c09a02278d6a5a5eef14c634cbdc 100644 --- a/tests/test_message.cpp +++ b/tests/test_message.cpp @@ -20,7 +20,6 @@ assert_equals(std::uint8_t(3), reader.version); assert_equals(std::uint32_t(1), reader.counter); assert_equals(std::size_t(10), reader.ratchet_key_length); assert_equals(std::size_t(10), reader.ciphertext_length); -assert_equals(std::size_t(8), reader.mac_length); assert_equals(ratchetkey, reader.ratchet_key, 10); assert_equals(ciphertext, reader.ciphertext, 10); @@ -47,7 +46,6 @@ std::memcpy(writer.mac, hmacsha2, 8); assert_equals(message2, output, 35); - } /* Message encode test */ }