From 23697e28a3f26b683a4fab309bb700f625414cd5 Mon Sep 17 00:00:00 2001
From: Nicolas Werner <nicolas.werner@hotmail.de>
Date: Wed, 25 Aug 2021 23:36:13 +0200
Subject: [PATCH] warn about online keybackup and default to off

---
 src/UserSettingsPage.cpp | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/UserSettingsPage.cpp b/src/UserSettingsPage.cpp
index ab1e442c3..82b294565 100644
--- a/src/UserSettingsPage.cpp
+++ b/src/UserSettingsPage.cpp
@@ -124,7 +124,7 @@ UserSettings::load(std::optional<QString> profile)
             .toBool();
         onlyShareKeysWithVerifiedUsers_ =
           settings.value(prefix + "user/only_share_keys_with_verified_users", false).toBool();
-        useOnlineKeyBackup_ = settings.value(prefix + "user/online_key_backup", true).toBool();
+        useOnlineKeyBackup_ = settings.value(prefix + "user/online_key_backup", false).toBool();
 
         disableCertificateValidation_ =
           settings.value("disable_certificate_validation", false).toBool();
@@ -1228,6 +1228,17 @@ UserSettingsPage::UserSettingsPage(QSharedPointer<UserSettings> settings, QWidge
         });
 
         connect(useOnlineKeyBackup_, &Toggle::toggled, this, [this](bool enabled) {
+                if (enabled) {
+                        if (QMessageBox::question(
+                              this,
+                              tr("Enable online key backup"),
+                              tr("The Nheko authors recommend not enabling online key backup until "
+                                 "symmetric online key backup is available. Enable anyway?")) !=
+                            QMessageBox::StandardButton::NoButton) {
+                                useOnlineKeyBackup_->setState(false);
+                                return;
+                        }
+                }
                 settings_->setUseOnlineKeyBackup(enabled);
         });
 
-- 
GitLab